solidity icon indicating copy to clipboard operation
solidity copied to clipboard

Fixes docs page width... I think...

Open MicahZoltu opened this issue 3 years ago • 2 comments

Fixes #13336 Adding this rule in my browser fixes the issue (see screenshots in issue for what it looks like). I'm guessing this file is the right place to add a new CSS rule to the page, but I'm not super confident about that part.

MicahZoltu avatar Aug 01 '22 09:08 MicahZoltu

Here's a before and after

before: https://output.circle-artifacts.com/output/job/1839fe06-7445-49a1-8622-48d9d78cb87d/artifacts/0/docs-html/introduction-to-smart-contracts.html after: https://output.circle-artifacts.com/output/job/27a7a6be-0d7f-4fca-b30f-1d1bb13e06f8/artifacts/0/docs-html/introduction-to-smart-contracts.html

Somewhat indifferent on the change. Maybe @franzihei has an opinion here.

Also, PR number 👀

hrkrshnn avatar Aug 01 '22 09:08 hrkrshnn

Hahaha! I didn't notice the PR number until you mentioned it, but that is some serious voodoo coincidence right there... 😖 I am willing to close this PR and open a new one if that is desired. 😬

MicahZoltu avatar Aug 01 '22 10:08 MicahZoltu

The general sentiment among EF UI experts was "do not do this", so I'm closing this for now :-). But this triggered some discussion about the docs theme, so there may be some changes upcoming due to this :-).

We can reopen, if https://github.com/ethereum/solidity/issues/13336 starts leaning towards doing this after all.

ekpyron avatar Aug 10 '22 15:08 ekpyron