solidity icon indicating copy to clipboard operation
solidity copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Calldata validation tests

Open wechman opened this issue 3 years ago • 1 comments

closes #12922

wechman avatar Jul 22 '22 10:07 wechman

Any reason for not adding // revertStrings: debug to all of them? If that doesn't cause issues, it may make it easy to properly check that this now catches all revert conditions.

ekpyron avatar Aug 02 '22 08:08 ekpyron

Any reason for not adding // revertStrings: debug to all of them? If that doesn't cause issues, it may make it easy to properly check that this now catches all revert conditions.

@ekpyron The reason is an error message that keeps changing in consecutive test runs. An example:

// f(uint256[][]): 0x20, 2, 0x40, 0xa0, 2, 5, 6, 3, 7, 8 -> FAILURE, 3963877391197344453575983046348115674221700746820753546331534351508065746944, 862718293348820473429344482784628181556388621521298319395315527974912, 0x2b414249206465636f64696e673a20696e76616c69642063616c6c6461, 52639898083992983106342913290719799829523823861698573317707643453664495927296, 0x4100000000000000c820b8edba5500000100000001000000

I guess we may want to fix that, but I am not sure if we should do that in scope of this ticket.

wechman avatar Aug 10 '22 10:08 wechman

Ah right, I vaguely remember that there's some legacy vs. via-IR differences with some of these cases - we should indeed try to fix that and align those eventually, but true, no need to burden this PR with that.

ekpyron avatar Aug 10 '22 10:08 ekpyron