solidity icon indicating copy to clipboard operation
solidity copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Added build flag to disable pedantic builds

Open YuviTz1 opened this issue 3 years ago • 2 comments

Added build flag DISABLE_WARNINGS which is OFF by default and disables warnings.

Potentially closes #13146

YuviTz1 avatar Jul 08 '22 14:07 YuviTz1

Thank you for the detailed review! I'll do the necessary changes.

YuviTz1 avatar Jul 18 '22 17:07 YuviTz1

The PR looks fine to me in the current form but the last thing that is missing is the extra bit of docs (https://github.com/ethereum/solidity/pull/13256#discussion_r923560310). Other than that, we could merge it right away.

cameel avatar Aug 05 '22 16:08 cameel

I added a bit of docs about the new flag. The PR is complete now.

cameel avatar Aug 11 '22 13:08 cameel