ethereum-org-website
ethereum-org-website copied to clipboard
Fixed #7904, Respect current language for filtering tutorials
Description
Filtering tutorials on /developers/tutorials wasn't considering a current language option, but default filteredTutorials was considered well. So I copied the logic for filtering with the current language respect.
Related Issue
https://github.com/ethereum/ethereum-org-website/issues/7904
:white_check_mark: ethereum-org-website-dev deploy preview ready
- Deploy preview
- Build logs · 18m build time
Hey @minhoryang!
Thanks for opening this. Your fix addressed some of the tag filtering which will be helpful, but while I was reviewing this I noticed a deeper issue. Turns out from the start, we are filtering out tutorials in the locale, instead of only showing tutorials in a locale.
As this is a pretty big bug we want to get fixed for tomorrows deploy we will fix that in this PR as well.
Again, thank you for opening this and helping as you did fix the original issue :)
@corwintines I've added the final filter when the user selects a tag.
~~As a bonus, I've also added the filtering on the tags but its experimental, check it out and let me know what do you think. We could do it differently without filtering the tags and only updating the tag numbers.~~ will leave it for a different PR
Woohoo, your important contribution to this open-source project has earned you a GitPOAP!
GitPOAP: 2022 Ethereum.org Contributor:

Head on over to GitPOAP.io and connect your GitHub account to mint!