ethereum-org-website icon indicating copy to clipboard operation
ethereum-org-website copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Bug report: Address overflow at REVERSE ENGINEERING A CONTRACT

Open saurabhburade opened this issue 1 year ago • 2 comments

Describe the bug

  • Address overflow

To reproduce

  1. Go to https://ethereum.org/en/developers/tutorials/reverse-engineering-a-contract/#0x81e580d3
  2. Mobile device view

Expected behavior

Wrap words/address

Screenshots

Screenshot 2024-10-09 at 1 14 41 PM

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

  • iPhone SE

Additional context

No response

Would you like to work on this issue?

  • [ ] Yes
  • [X] No

saurabhburade avatar Oct 09 '24 07:10 saurabhburade

Thanks @saurabhburade

I think this will have a similar solution to the docs overflow that was done in https://github.com/ethereum/ethereum-org-website/pull/14050/files for whoever picks this up

corwintines avatar Oct 09 '24 20:10 corwintines

@corwintines can I work on this ?

Signor1 avatar Oct 17 '24 15:10 Signor1

For sure, assigned to you @Signor1!

corwintines avatar Oct 21 '24 14:10 corwintines

@Signor1 just checking in to see if theres anything you need?

corwintines avatar Oct 28 '24 17:10 corwintines

Hi @corwintines, I'm working on it. I got delayed in cloning the repo due to the size

Signor1 avatar Oct 28 '24 22:10 Signor1

Hi @corwintines, I just created a PR #14254

Signor1 avatar Oct 29 '24 15:10 Signor1

Hi @Signor1, Great! Few suggestions here

  • Use tailwind classes instead of using custom CSS
  • Follow https://github.com/ethereum/ethereum-org-website#how-to-contribute guide [prefer yarn]
  • I'd recommend to only modify src/layouts/Tutorial.tsx, unless there's dependency.

saurabhburade avatar Oct 29 '24 16:10 saurabhburade

Thank you @saurabhburade for the guidance. I've made the corrections and then created a PR #14256

Signor1 avatar Oct 29 '24 21:10 Signor1