ERCs icon indicating copy to clipboard operation
ERCs copied to clipboard

Add ERC: Splitting and Merging of NFTs

Open nitin312 opened this issue 9 months ago • 15 comments

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

nitin312 avatar Feb 27 '25 07:02 nitin312

✅ All reviewers have approved.

eip-review-bot avatar Feb 27 '25 07:02 eip-review-bot

You have two PRs open for the same proposal? PR 923 , PR 920

bomanaps avatar Feb 27 '25 20:02 bomanaps

@eip-review-bot, could you please review this PR #930? It's passed all checks and is ready for merging. If there's anything I need to address, please let me know. Thanks!

nitin312 avatar Mar 26 '25 10:03 nitin312

@eip-review-bot @g11tech @SamWilsn @xinbenlv
Would you kindly take a review of PR #930 for proposal ERC-7891? The proposal has passed all required checks and is ready for merging. Let me know if there are any final changes needed. Thanks!

nitin312 avatar Mar 28 '25 11:03 nitin312

Hi @eip-review-bot, @bomanaps, All required checks have passed for this PR #930. It's been open for a while and is awaiting review. Would you mind taking a look when you have a moment? Please let me know if any further changes are needed. Thanks in advance!

nitin312 avatar Apr 08 '25 07:04 nitin312

Hi again @bomanaps, @eip-review-bot — just following up to kindly check if this PR (#930) might be reviewed soon. Happy to make any updates needed. Thanks again!

nitin312 avatar Apr 11 '25 07:04 nitin312

Hi again @bomanaps, @eip-review-bot — just following up to kindly check if this PR (https://github.com/ethereum/ERCs/pull/930) might be reviewed soon. Happy to make any updates needed. Thanks again!

nitin312 avatar Apr 14 '25 10:04 nitin312

reviewed

Can you make it to the call tomorrow 4pm utc?

bomanaps avatar Apr 14 '25 18:04 bomanaps

reviewed

Can you make it to the call tomorrow 4pm utc?

@bomanaps Thanks for reviewing! Yes, I can make it to the call at 4 PM UTC. Looking forward to it!

nitin312 avatar Apr 15 '25 02:04 nitin312

Hi @bomanaps, Yes, I can make it to the call tomorrow at 4 PM UTC. How will I join the call? Please share the details. Looking forward to the discussion! Thanks

On Tue, Apr 15, 2025 at 3:13 AM Mercy Boma Naps Nkari < @.***> wrote:

reviewed

Can you make it to the call tomorrow 4pm utc?

— Reply to this email directly, view it on GitHub https://github.com/ethereum/ERCs/pull/930#issuecomment-2802529793, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4YJQJ3WZJC7NK46TGB4WWL2ZP3EPAVCNFSM6AAAAABX7CCY62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBSGUZDSNZZGM . You are receiving this because you authored the thread.Message ID: @.***> bomanaps left a comment (ethereum/ERCs#930) https://github.com/ethereum/ERCs/pull/930#issuecomment-2802529793

reviewed

Can you make it to the call tomorrow 4pm utc?

— Reply to this email directly, view it on GitHub https://github.com/ethereum/ERCs/pull/930#issuecomment-2802529793, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4YJQJ3WZJC7NK46TGB4WWL2ZP3EPAVCNFSM6AAAAABX7CCY62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBSGUZDSNZZGM . You are receiving this because you authored the thread.Message ID: @.***>

nitin312 avatar Apr 15 '25 04:04 nitin312

Hi @bomanaps, Yes, I can make it to the call tomorrow at 4 PM UTC. How will I join the call? Please share the details. Looking forward to the discussion! Thanks On Tue, Apr 15, 2025 at 3:13 AM Mercy Boma Naps Nkari < @.> wrote: reviewed Can you make it to the call tomorrow 4pm utc? — Reply to this email directly, view it on GitHub <#930 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4YJQJ3WZJC7NK46TGB4WWL2ZP3EPAVCNFSM6AAAAABX7CCY62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBSGUZDSNZZGM . You are receiving this because you authored the thread.Message ID: @.> bomanaps left a comment (ethereum/ERCs#930) <#930 (comment)> reviewed Can you make it to the call tomorrow 4pm utc? — Reply to this email directly, view it on GitHub <#930 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4YJQJ3WZJC7NK46TGB4WWL2ZP3EPAVCNFSM6AAAAABX7CCY62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBSGUZDSNZZGM . You are receiving this because you authored the thread.Message ID: @.***>

Please find details of the call here: https://github.com/ethereum/pm/issues/1440

bomanaps avatar Apr 15 '25 13:04 bomanaps

The commit 0843dc8b09a72a1e91f19e70dfc228fc61d3e469 (as a parent of 311bb15083c955b1ec8b172167625fbe0fee009f) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Apr 24 '25 10:04 github-actions[bot]

@SamWilsn, @bomanaps, and @eip-review-bot, could you please take a moment to review this pull request? It includes the final draft of the ERC-7891 proposal and related code changes.

Your feedback would be greatly appreciated before we proceed with merging. Let me know if you have any questions or need further clarifications!

Thanks in advance!

nitin312 avatar Apr 25 '25 12:04 nitin312

@SamWilsn, @bomanaps, and @eip-review-bot, could you please take a moment to review this pull request? It includes the draft of the ERC-7891 proposal and related code changes.

Your feedback would be greatly appreciated before we proceed with merging. Let me know if you have any questions or need further clarifications!

Thanks in advance!

nitin312 avatar May 05 '25 09:05 nitin312

@SamWilsn, @bomanaps, and @eip-review-bot, could you please take a moment to review this pull request? It includes the draft of the ERC-7891 proposal and related code changes. It has been a long time waiting for review.

Your feedback would be greatly appreciated before we proceed with merging. Let me know if you have any questions or need further clarifications!

Thanks in advance!

nitin312 avatar May 13 '25 09:05 nitin312

Hi @eip-review-bot, @bomanaps, @SamWilsn — all checks have passed and one review has been approved. Kindly review the PR when you get a chance. Thank you!

nitin312 avatar May 26 '25 05:05 nitin312