ERCs icon indicating copy to clipboard operation
ERCs copied to clipboard

Update ERC-7683: 'open' and 'fill' methods should be payable

Open Zodomo opened this issue 1 year ago • 2 comments

Making the open methods payable allows for natives to trivially be used in user requests. Native payment can easily be accounted for alongside ERC-20 tokens by using address(0). Adding the payable modifier will make it much easier for integrators to account for native payments. This logic also follows for fill, as fillers might need to provide native payment to the settlement contract to fulfill the user's order. It seems like an anti-pattern to require handling native payment in functions outside of the spec.

Zodomo avatar Dec 14 '24 01:12 Zodomo

File ERCS/erc-7683.md

Requires 1 more reviewers from @marktoda, @mrice32, @nicholaspai

eip-review-bot avatar Dec 14 '24 01:12 eip-review-bot

There has been no activity on this issue for six months. It will be closed in 7 days if there is no new activity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Oct 09 '25 00:10 github-actions[bot]