ethereum
Add ERC: Quantum Supremacy Bounty
File ERCS/erc-7826.md
Requires 1 more reviewers from @g11tech, @samwilsn, @xinbenlv
Is there a prior example of adding an entire sol repo with dependencies to the assets folder?
Is there a prior example of adding an entire sol repo with dependencies to the assets folder?
This looks like the largest set of assets compared to other ERCs, though it does not seem uncommon to include implementations (e.g., 6358, 6220, 5252, etc.). We may not need all of the assets in this ERC, but they do provide proof of the statements contained in this ERC, including tests and comparisons to other potential puzzles.
The commit 29d3f918cb3a92f1a85c59d2f1b6cbce5a003e35 (as a parent of e90390930ab2a6faeb1d39efd6ab8cec048ac08f) contains errors. Please inspect the Run Summary for details.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This proposal doesn't require an EIP/ERC. Simply deploy the contract.
When discussing this with Danny Ryan (@djrtwo), we decided that this should be deployed as a singleton as it should be a single instance across any chain. So, wouldn't this require ERC-2470: Singleton Factory? Although, I see that it is in a "stagnant" stage, so I can see why we might not want to mark it as dependent on that. Would you still like me to remove the explicit dependency but still require deploying as a singleton?
Deploying a singleton is totally acceptable. The issue is that, because there is only one implementation, you don't need a standard. You can just read the comments in that code and you're good to go. You only need an ERC when multiple different parties need to interact (like all wallets need to work with all ERC-20 tokens).
There has been no activity on this issue for six months. It will be closed in 7 days if there is no new activity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.