ERCs icon indicating copy to clipboard operation
ERCs copied to clipboard

Update ERC-7540: Fix event names

Open eyqs opened this issue 1 year ago • 3 comments

The DepositRequest and RedeemRequest events were mistyped as RequestDeposit and RequestRedeem.

Also adds minor punctuation fixes.

eyqs avatar Oct 10 '24 08:10 eyqs

File ERCS/erc-7540.md

Requires 2 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @xinbenlv

eip-review-bot avatar Oct 10 '24 08:10 eip-review-bot

Implementations MUST support an additional overloaded deposit and mint method on the specification from ERC-4626, with an additional controller input of type address:

When the Deposit event is emitted, the first parameter MUST be the controller, and the second parameter MUST be the receiver.

IMO that Deposit event is new and is part of the standard therefore it must be added under the Events section with the correct signature.

peculiarity avatar Oct 10 '24 08:10 peculiarity

I think the Deposit event remains the same with the same parameters and parameter names. This EIP just specifies that that the implementation should emit Deposit(controller, receiver, assets, shares) - i.e. the sender is always the controller and the owner is always the receiver.

eyqs avatar Oct 10 '24 18:10 eyqs