ERCs
ERCs copied to clipboard
Update ERC-7578: Move to Last Call
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:
- The PR edits only existing draft PRs.
- The build passes.
- Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside
. - If matching on email address, the email address is the one publicly listed on your GitHub profile.
File ERCS/erc-7578.md
Requires 1 more reviewers from @axic, @g11tech, @samwilsn, @xinbenlv
Are the PropertiesSet and PropertiesRemoved events emitted when the token is minted / burned, if properties are attached at that time?
Yes, the PropertiesSet MUST be emitted when prior to minting the token. In other words, the ERC-7578 properties should be set before minting time. The PropertiesRemoved MUST be emitted after the token is burned. A full example implementation can be found here.
Your security consideration applies just to your reference implementation. You should either move it to that section, or reword it so that it applies to any implementation (which I think is possible in this case.)
Thanks for pointing to this! I've reworded to ensure it applies to any implementation.
Merged in #819