ERCs icon indicating copy to clipboard operation
ERCs copied to clipboard
verified publisher icon ethereum

Add ERC: JSON-RPC API for ERC-4337

Open forshtat opened this issue 1 year ago • 6 comments

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

forshtat avatar Sep 10 '24 15:09 forshtat

✅ All reviewers have approved.

eip-review-bot avatar Sep 10 '24 15:09 eip-review-bot

@forshtat my understanding is that API standards should be directed to https://github.com/ethereum/execution-apis rather than create an EIP/ERC

abcoathup avatar Sep 11 '24 00:09 abcoathup

@forshtat my understanding is that API standards should be directed to https://github.com/ethereum/execution-apis rather than create an EIP/ERC

This is not an ethereum node RPC-API, but an API for an external entity (bundler) that supports the ERC-4337 standard itself. Currently, the RPC-API is defined inside the ERC-4337 itself. However, the RPC-API is less stable than ERC-4337 itself (which defines the contract interfaces), and prevents us from finalizing the contracts interfaces in ERC-4337 contracts, so we want to extract the RPC from it. Currently, JSON-RPC's are in the EIP repository, but it would seem a bit odd to create an EIP to define the JSON-RPC of ERC-4337...

drortirosh avatar Sep 17 '24 13:09 drortirosh

The commit 392299c4d5c6155577fe3d81532490b1b39f84b0 (as a parent of a5fdbec4b82d7af55c86683026337d3701f14960) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Sep 18 '24 14:09 github-actions[bot]

@abcoathup : can this PR be merged?

drortirosh avatar Sep 19 '24 15:09 drortirosh

@drortirosh you need an ERC editor to review (I am not an editor). There is only a small number of editors, so it can take some time to get reviewed. In the meantime, ensure that the validator doesn’t raise any errors & fix any issues.

There is a fortnightly office hours that you could attend: https://github.com/ethcatherders/EIPIP/issues/360

abcoathup avatar Sep 20 '24 04:09 abcoathup