ERCs icon indicating copy to clipboard operation
ERCs copied to clipboard

Add ERC-XXXX

Open 1999321 opened this issue 1 year ago • 3 comments

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

1999321 avatar Jul 08 '24 10:07 1999321

🛑 eip-review-bot failed for an unknown reason. Please see logs for more details, and report this issue at the eip-review-bot repository.

eip-review-bot avatar Jul 08 '24 10:07 eip-review-bot

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Alchemy API Key 154e08ae692adc9b0e753b15cac76e8332305ff2 assets/erc-xxxx/lib/forge-std/src/StdChains.sol View secret
- Alchemy API Key 154e08ae692adc9b0e753b15cac76e8332305ff2 assets/erc-xxxx/lib/forge-std/foundry.toml View secret
- Alchemy API Key 154e08ae692adc9b0e753b15cac76e8332305ff2 assets/erc-xxxx/lib/forge-std/test/StdChains.t.sol View secret
- Alchemy API Key 154e08ae692adc9b0e753b15cac76e8332305ff2 assets/erc-xxxx/lib/forge-std/test/StdChains.t.sol View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

If this detection is a false positive, please contact Oleh Vasylenko (@aldekein) to fix it in the GitGuardian dashboard.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Jul 08 '24 10:07 gitguardian[bot]

The commit 6226647bbf6298a6fac79ee3dbf077276400c452 (as a parent of bb2bb4f6e81ffca7ea0d94bc516435a93f34aec3) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 08 '24 10:07 github-actions[bot]

There has been no activity on this issue for six months. It will be closed in 7 days if there is no new activity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Mar 01 '25 00:03 github-actions[bot]