ERCs icon indicating copy to clipboard operation
ERCs copied to clipboard

Update ERC-3009: Change the order of chainId and verifyingContract address

Open dongri opened this issue 1 year ago • 2 comments

There is an error in signature verification with the current sample code.

EIP3009: invalid signature

It is necessary to change the order of bytes32(chainId) and address(this) to comply with keccak256("EIP712Domain(string name,string version,uint256 chainId,address verifyingContract)").

dongri avatar Jun 22 '24 08:06 dongri

File ERCS/erc-3009.md

Requires 1 more reviewers from @davidlknott, @kbrizzle, @petejkim

eip-review-bot avatar Jun 22 '24 08:06 eip-review-bot

Isn't anyone going to review it?

dongri avatar Jun 27 '24 13:06 dongri

The commit 4f950c2fabac1485f3367fd470beeb4c5b1598dd (as a parent of 302c0c55cbbb03eb3037d292513cac8c67e7f3c5) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 20 '24 21:08 github-actions[bot]

I can approve this as an Editor, but you'll need to wait for one of the proposal authors to approve the pull request before it is merged.

Alternatively, if you'd like to champion this proposal, you can copy the text into a new proposal (adding yourself as an author) pull request.

@SamWilsn Thank you for your review. When submitting a pull request with a new proposal, do I need to change the EIP number? Should it be +1 from the latest EIP?

dongri avatar Aug 20 '24 22:08 dongri

@SamWilsn https://github.com/ethereum/EIPs/pull/8819

dongri avatar Aug 20 '24 23:08 dongri

@dongri to create a new ERC please create the PR in the ERC repo. An ERC number will be manually assigned by an editor/associate.

abcoathup avatar Aug 21 '24 00:08 abcoathup

@abcoathup Thanks! https://github.com/ethereum/ERCs/pull/598

dongri avatar Aug 21 '24 01:08 dongri