ERCs icon indicating copy to clipboard operation
ERCs copied to clipboard

Add ERC: Common Quote Oracle

Open alcueca opened this issue 1 year ago • 10 comments

For a while now a bunch of us have been toiling on what is now a minimal standard for oracle value feeds. This all probably started when I wrote this article about using value conversions instead of prices in smart contracts:

In very short, this is a minimal standard with a single function to get the value of an amount of an asset in terms of another asset. There are a number of adapters for current oracles from the community and from Euler.

alcueca avatar Jun 20 '24 10:06 alcueca

✅ All reviewers have approved.

eip-review-bot avatar Jun 20 '24 10:06 eip-review-bot

Oh great, now it seems to be stuck. Could I get some help here?

alcueca avatar Jun 20 '24 15:06 alcueca

The commit b56fd9a4155b151ea19a06e5ba5021ac1251836b (as a parent of 1c856247bcfbb464a2a03b4d241592a2e0a2988a) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jun 24 '24 08:06 github-actions[bot]

Alright, CI passes, could we please get this merged into draft, @axic, @g11tech, @SamWilsn, @xinbenlv?

alcueca avatar Jun 24 '24 08:06 alcueca

Also, maybe make this a bit more prominent or fix it. This was quite an adventure.

image

https://github.com/ethereum/ERCs/issues/8

alcueca avatar Jun 24 '24 08:06 alcueca

If there aren't any more comments, could we please get this merged, please?

@axic, @g11tech, @SamWilsn, @xinbenlv

alcueca avatar Jul 01 '24 14:07 alcueca

Henloooooo, could we please get this merged?

@axic, @g11tech, @SamWilsn, @xinbenlv

alcueca avatar Jul 09 '24 07:07 alcueca

@abcoathup, is there anything that we can do to please move this along?

alcueca avatar Jul 09 '24 07:07 alcueca

@abcoathup, is there anything that we can do to please move this along?

@alcueca you need an ERC editor to review. (Which I am not)

You could try attending EIP office hours. https://github.com/ethcatherders/EIPIP/issues/342

abcoathup avatar Jul 09 '24 14:07 abcoathup

@abcoathup, do you have any idea how to debug that jekyll job that is failing? There is not much between the commit that was working, and the commit where it started not to work.

alcueca avatar Jul 11 '24 08:07 alcueca