ERCs icon indicating copy to clipboard operation
ERCs copied to clipboard

Add ERC: Distinguishable base256emoji Addresses

Open wjmelements opened this issue 1 year ago • 8 comments

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

wjmelements avatar Mar 31 '24 23:03 wjmelements

✅ All reviewers have approved.

eip-review-bot avatar Mar 31 '24 23:03 eip-review-bot

Needs to be assigned ERC number since it's no-longer just the PR. Otherwise this would be ERC-354.

wjmelements avatar Mar 31 '24 23:03 wjmelements

Error: file name "erc-draft_distinguishable_account_addresses" not in correct format

hmm I really thought it was in the correct format. Perhaps it only wants the ERC number to be assigned.

From ERC-Template:

When opening a pull request to submit your EIP, please use an abbreviated title in the filename, eip-draft_title_abbrev.md.

I picked the name ERCS/erc-draft_distinguishable_account_addresses.md therefore since this is the ERC repo, after assuming the eip- template was a remnant of the repository's split from EIPs. Perhaps it is not sufficiently abbreviated.

wjmelements avatar Apr 01 '24 00:04 wjmelements

Thanks @abcoathup

wjmelements avatar Apr 02 '24 05:04 wjmelements

The commit 7c6854f5e9f4d96393e539406bd1348abb7afde6 (as a parent of 89329cbd8ed55790c76c759585453b0618429a09) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Apr 02 '24 05:04 github-actions[bot]

For the Links > Internal check, the following failures were found:

* At ./_site/EIPS/eip-7673.html:208:

  internally linking to ./erc-20.md, which does not exist

* At ./_site/EIPS/eip-7673.html:[15](https://github.com/ethereum/ERCs/actions/runs/8517744456/job/23328806087?pr=354#step:8:16)38:

  internally linking to ./erc-55.md, which does not exist

hmm

wjmelements avatar Apr 02 '24 05:04 wjmelements

I'd just like to confirm that you want to pursue this before I invest any time in reviewing, considering the day it was posted.

SamWilsn avatar Apr 05 '24 00:04 SamWilsn

Yes please

On Thu, Apr 4, 2024 at 7:20 PM Sam Wilson @.***> wrote:

I'd just like to confirm that you want to pursue this before I invest any time in reviewing, considering the day it was posted.

— Reply to this email directly, view it on GitHub https://github.com/ethereum/ERCs/pull/354#issuecomment-2038488260, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGDGVK6FHLX5CVKQKTGCMTY3XU6TAVCNFSM6AAAAABFQZOGASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZYGQ4DQMRWGA . You are receiving this because you authored the thread.Message ID: @.***>

wjmelements avatar Apr 05 '24 00:04 wjmelements