ERCs icon indicating copy to clipboard operation
ERCs copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Update ERC-4824: Move to Review

Open thelastjosh opened this issue 1 year ago • 2 comments

I moved the example contract to the assets folder, made various minor clarifications about how daoURI and indexing should work, supplemented the rationale, changed the id format for members to align more closely with CAIP-10 (already used for proposals), and fixed a bunch of typos. All changes are backward compatible.

thelastjosh avatar Mar 19 '24 12:03 thelastjosh

✅ All reviewers have approved.

eip-review-bot avatar Mar 19 '24 12:03 eip-review-bot

The commit 2103dc768bdcacfcd01a204175572fa4a8bba514 (as a parent of fb4e937f153becd43d3b9154a9e786f820a6fb49) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Mar 19 '24 13:03 github-actions[bot]

Responded to all review suggestions, moved the smart contract out into assets. Should be ready to move to review!

thelastjosh avatar Jun 11 '24 13:06 thelastjosh

@SamWilsn @xinbenlv or other EIP editor, just a ping so this change can get finally merged! 🙏

thelastjosh avatar Jun 11 '24 16:06 thelastjosh

Put up a pull request with some minor fixes: https://github.com/thelastjosh/ERCs/pull/3

SamWilsn avatar Jun 11 '24 18:06 SamWilsn

Put up a pull request with some minor fixes: thelastjosh#3

Merged!

thelastjosh avatar Jun 11 '24 18:06 thelastjosh

Thank you!!

thelastjosh avatar Jun 12 '24 21:06 thelastjosh