ERCs icon indicating copy to clipboard operation
ERCs copied to clipboard

Update ERC-7521: Add Prohibited Address Description

Open Karotoka opened this issue 1 year ago • 5 comments

Adding the description of the functions included in the PR here.

Attempted to mirror the existing structure but feel free to edit or reject if inappropriate.

Karotoka avatar Mar 17 '24 21:03 Karotoka

File ERCS/erc-7521.md

Requires 1 more reviewers from @pixelcircuits, @supiket

eip-review-bot avatar Mar 17 '24 21:03 eip-review-bot

This would be better suited as an intent standard for ERC-7521 rather than being baked into the entrypoint itself. This way it's up to users to opt in and include a segment on their intent with these extra constraints.

Also, the full list of possibly touched contracts isn't fully known by just looking at intent data. For example, imagine a wrapper contract that just forwards calls to another contract, with the intent of obscuring the target contracts address.

pixelcircuits avatar Mar 17 '24 23:03 pixelcircuits

This makes sense to me as the functionality is designed to be optional.

Can you direct me towards the correct repo that this should live in and I will submit it there? I'm a poor wordcell struggling through GitHub and had a hunch this may have been the wrong spot.

As for the possibly touched contracts - yes, I understand that structure and packing of intentData may cause problems extracting prohibited addresses. I don't think this can be resolved in the ERC7521 standard itself. The goal is to set a framework that users/builders can iterate on depending on their specs.

Karotoka avatar Mar 18 '24 19:03 Karotoka

I think it makes the most sense to write an example intent standard contract and add it here. At least one that whitelists a solver by checking msg.origin.

pixelcircuits avatar Mar 18 '24 22:03 pixelcircuits

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Aug 15 '24 00:08 github-actions[bot]

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

github-actions[bot] avatar Feb 22 '25 00:02 github-actions[bot]