EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Update EIP-658: fix grammar

Open RenanSouza2 opened this issue 1 year ago • 2 comments

In this PR one grammar mistake is fixed

RenanSouza2 avatar Oct 02 '24 14:10 RenanSouza2

File EIPS/eip-658.md

Requires 1 more reviewers from @lightclient, @samwilsn, @xinbenlv

eth-bot avatar Oct 02 '24 14:10 eth-bot

The commit 0f7d2518f6f1257641afa1f4f47f88ff2b7d0ad5 (as a parent of 50f1a9c4c91d43bca884b88613927ce132522da3) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Oct 02 '24 14:10 github-actions[bot]

There has been no activity on this issue for six months. It will be closed in 7 days if there is no new activity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Apr 18 '25 00:04 github-actions[bot]

Are we sure this isn't "if and only if"?

I agree with you that "if and only if" is better but it's not really my place to approve the changes

RenanSouza2 avatar May 08 '25 00:05 RenanSouza2

I agree with you that "if and only if" is better but it's not really my place to approve the changes

I mean more that "iff" is a commonly accepted shorthand for "if and only if", so getting rid of the "f" would change the meaning.

SamWilsn avatar May 27 '25 16:05 SamWilsn

Agree with Sam. Will err on side of caution and simply close this PR.

lightclient avatar May 28 '25 00:05 lightclient