EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Update EIP-196: Fix coordinate description

Open sylvainpelissier opened this issue 1 year ago • 2 comments
trafficstars

The current EIP-197 specifies the point coordinate to be a "Jacobian pair". However the current representation is the affine coordinates not Jacobian. See for example in the book Handbook of Elliptic and Hyperelliptic Curve Cryptography Section 13.2.1 or in the Halo2 documentation

To avoid implementation mistakes this PR corrects the coordinate definition and clarify it in EIP-196.

sylvainpelissier avatar Jul 18 '24 09:07 sylvainpelissier

File EIPS/eip-196.md

Requires 2 more reviewers from @g11tech, @lightclient, @samwilsn, @xinbenlv

File EIPS/eip-197.md

Requires 2 more reviewers from @g11tech, @lightclient, @samwilsn, @xinbenlv

eth-bot avatar Jul 18 '24 09:07 eth-bot

The commit 350b33e97dd127f5c4f7138329d30dcaf4d3b9b5 (as a parent of 09cf3f1d038f5ded509675d808fdcfe0adc9a8b8) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 18 '24 09:07 github-actions[bot]

There has been no activity on this issue for six months. It will be closed in 7 days if there is no new activity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Jan 18 '25 00:01 github-actions[bot]

I am not qualified to approve or reject this change. I'll make sure it comes up on the next EIPIP.

SamWilsn avatar Mar 22 '25 13:03 SamWilsn

There has been no activity on this issue for six months. It will be closed in 7 days if there is no new activity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Oct 26 '25 00:10 github-actions[bot]