Update EIP-712: Fix incorrect byte counts

[jshufro]

The current byte counts are plainly wrong and easy to fix. The first commit fixes it. The second gets the linter to be quiet - excepting a couple spurious errors.

The example signature only has 65 bytes, but is said to 129 bytes:

$ echo -n "0x4355c47d63924e8a72e509b65029052eb6c299d53a04e167c5775fd466751c9d07299936d304c153f6443dfa05f40ff007d72911b6f72307f996231605b915621c" | wc -c
132

Removing 2 characters for the 0x prefix leaves 130 characters of hex, which encodes only 65 bytes.

(Oddly, the "last byte" on top of 128 bytes is counted as 1 character instead of 2)

Appendix F of the yellow paper and the function signature in EIP-191 (signatureBasedExecution(address target, uint256 nonce, bytes memory payload, uint8 v, bytes32 r, bytes32 s) public payable) reaffirm that these fields are 32 bytes, ergo 64 characters of hex, or when combined, 64 byte ergo 128 characters of hex. The final byte is one byte and 2 characters of hex for 65 total bytes and 130 hex characters, or 132 with the prefix.

[eth-bot]

File EIPS/eip-712.md

Requires 1 more reviewers from @dekz, @logvinovleon, @recmo Requires 2 more reviewers from @axic, @g11tech, @gcolvin, @samwilsn, @xinbenlv

[jshufro]

The remaining linter errors feel very much out of my jurisdiction :sob:

[Parasos]

ok

[SamWilsn]

@jshufro thanks for the contribution! For Final proposals, you should completely ignore the linter and make only the minimal required change. Since you have them in separate commits, just remove 1de8cf44f01334f97f791cdb023feb0a57135d96.

[jshufro]

I've rebased and dropped 1de8cf4

[github-actions[bot]]

The commit 188f7aa0daf404a4e9399b4d1869ddb1b70b82d0 (as a parent of c7d84ae5f2d685f69625fe82b08a1b36354d73fe) contains errors. Please inspect the Run Summary for details.

[jshufro]

@jshufro thanks for the contribution! For Final proposals, you should completely ignore the linter and make only the minimal required change. Since you have them in separate commits, just remove 1de8cf4.

Anything I need to do to move this forwards?