EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Update EIP-152: Fix reference test

Open chfast opened this issue 1 year ago • 4 comments

The solidity example with the reference test of https://datatracker.ietf.org/doc/html/rfc7693#appendix-A is at least confusing because it declares values of type bytes8 using a literal of length of 4 bytes.

chfast avatar Apr 04 '24 22:04 chfast

File EIPS/eip-152.md

Requires 1 more reviewers from @madeoftin, @mhluongo, @pdyraga

eth-bot avatar Apr 04 '24 22:04 eth-bot

For this kind of fix, can we just lower the requirement to just 2 editor-s approval? or even one should be ok

xinbenlv avatar Jun 05 '24 17:06 xinbenlv

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Jun 26 '24 00:06 github-actions[bot]

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

github-actions[bot] avatar Aug 07 '24 00:08 github-actions[bot]

The commit 8da81cea5316c2df210d9ba6decd7a5e70fb628d (as a parent of 447384db0c21bcf88f18d1afc9cbb6a032317fa0) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 20 '24 12:08 github-actions[bot]

Thank you for handling this.

chfast avatar Aug 20 '24 16:08 chfast