EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Grab latest `eipw`, which won't block stagnant bot

Open SamWilsn opened this issue 3 years ago • 3 comments
trafficstars

The latest version of eipw will report warnings instead of errors for EIPs with a Stagnant status. This should let the stagnant bot work properly.

SamWilsn avatar Nov 16 '22 21:11 SamWilsn

All tests passed; auto-merging...

(pass) .github/workflows/ci.yml

classification
ambiguous
  • file .github/workflows/ci.yml is not a valid filename, but this error has been ignored due to editor approvals

eth-bot avatar Nov 16 '22 21:11 eth-bot

What about htmlproofer and codespell? Codespell was not enforced for a long time, so there are at least 6 EIPs that have codespell errors.

Now that I think about it, there's a new github feature to add custom roles. Bypassing branch protection is one of the options: https://github.blog/changelog/2022-08-18-bypass-branch-protections-with-a-new-permission/. Could we get this set up?

Pandapip1 avatar Nov 17 '22 13:11 Pandapip1

What about htmlproofer and codespell? Codespell was not enforced for a long time, so there are at least 6 EIPs that have codespell errors.

Not sure what to do about those. I just noticed a wave of PRs (eg. #5973) that are only blocked on eipw results.

Now that I think about it, there's a new github feature to add custom roles. Bypassing branch protection is one of the options: https://github.blog/changelog/2022-08-18-bypass-branch-protections-with-a-new-permission/. Could we get this set up?

You'd like to give that permission to editors? I'll look into it.

SamWilsn avatar Nov 17 '22 16:11 SamWilsn

No, I meant give that permission to @eth-bot, which will then be able to bypass the checks

Pandapip1 avatar Nov 18 '22 17:11 Pandapip1

Actually, I found https://github.blog/changelog/2021-11-19-allow-bypassing-required-pull-requests/. Can we add @eth-bot to this list?

Pandapip1 avatar Nov 18 '22 17:11 Pandapip1