EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Update EIP-1898: Move to draft

Open macfarla opened this issue 3 years ago • 4 comments
trafficstars

Signed-off-by: Sally MacFarlane [email protected]

It is supported by Geth 1.9.6 (PR). It is supported by Besu 20.10.4 (PR).

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

macfarla avatar Nov 16 '22 04:11 macfarla

A critical exception has occurred: Message: pr 5980 is already merged; quitting (cc @alita-moore, @mryalamanchi)

eth-bot avatar Nov 16 '22 04:11 eth-bot

This could probably be moved to review or final stage. It has been implemented and stable in clients for years now.

charles-cooper avatar Nov 16 '22 06:11 charles-cooper

Details

Thanks @charles-cooper - changed to Review

macfarla avatar Nov 16 '22 06:11 macfarla

opened a separate PR for moving EIP-1474 back to draft also https://github.com/ethereum/EIPs/pull/5986

macfarla avatar Nov 17 '22 01:11 macfarla

LGTM: the author approved and the update seems reasonable, agree to move back to Draft.

In terms of moving to Review -> Final, I love to see if we can accelerate that process if this EIP have been stable and implemented by clients. Editors to discuss

xinbenlv avatar Nov 20 '22 15:11 xinbenlv