EIPs
EIPs copied to clipboard
ethereum
CI: Warn on non-relative links and on extra sections
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
(fail) .github/workflows/ci.yml
| classification |
|---|
ambiguous |
- '.github/workflows/ci.yml' must be in eip-###.md format; this error will be overwritten upon relevant editor approval
May I ask why we're switching to warnings?
- Some external links are now allowed
- EIP-1 doesn't say that you can't use sections not defined in EIP-1
- Some external links are now allowed
Those exceptions are already supported:
https://github.com/ethereum/eipw/blob/4e4bc7b50a094ea9b02551113780b380a096120d/eipw-lint/src/lib.rs#L360-L363
- EIP-1 doesn't say that you can't use sections not defined in EIP-1
While true, I'm not convinced we should allow extra sections without specific editor approval?
I'm not convinced we should allow extra sections without specific editor approval?
Agreed, but on the other hand I'm not convinced that we should require a manual merge to allow extra sections.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I too am firmly against out of order sections. Might it be possible to separate those two lints?
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.