EIPs
EIPs copied to clipboard
Include Ganache private chains (5777) in EIP-155
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:
- The PR edits only existing draft PRs.
- The build passes.
- Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside
. - If matching on email address, the email address is the one publicly listed on your GitHub profile.
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
(fail) eip-155.md
| classification |
|---|
updateEIP |
- eip-155.md is in state final at the head commit, not draft or last call or review; an EIP editor needs to approve this change
- This PR requires review from one of [@lightclient, @axic, @gcolvin, @samwilsn, @pandapip1]
- eip-155.md requires approval from one of (@vbuterin)
Not sure this is still valid, Ganache uses 1337/5777 which means the network id is common but not the same as the chain...
We've discussed this change on today's EIPIP, and we will not be modifying EIP-155 to add this chain id.
EIPs are not the best place to maintain tables that are intended to change over time.