EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Move to Last Call

Open buzzcai opened this issue 3 years ago • 1 comments
trafficstars

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

buzzcai avatar Oct 20 '22 23:10 buzzcai

All tests passed; auto-merging...

(pass) eip-5484.md

classification
updateEIP
  • passed!

eth-bot avatar Oct 20 '22 23:10 eth-bot

@Pandapip1 Markdown Linter is failing with "Error: Failed due to error: Error: ENOENT: no such file or directory, open 'config/.markdownlint.yaml'" while .markdownlint.yaml is in config directory last time I checked.

buzzcai avatar Oct 23 '22 18:10 buzzcai

@Pandapip1 done

buzzcai avatar Oct 23 '22 23:10 buzzcai

There's a newline missing between L74 and L75.

On L76, there's a minor grammatical eror.

@Pandapip1 do you mind pointing out the grammatical error on L76? (now L77)

buzzcai avatar Oct 24 '22 17:10 buzzcai