EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Add EIP-5805: Voting with delegation

Open Amxx opened this issue 3 years ago • 5 comments
trafficstars

Amxx avatar Oct 20 '22 10:10 Amxx

All tests passed; auto-merging...

(pass) eip-5805.md

classification
updateEIP
  • passed!

eth-bot avatar Oct 20 '22 10:10 eth-bot

We might need to rename the now() function, because of name conflicts with solidity's now keyword (deprecated since 0.7.0 but still raising issues).

Should we go for clock() ?

Amxx avatar Oct 31 '22 11:10 Amxx

clock sounds good to me. Another alternative could be tick.

frangio avatar Nov 04 '22 16:11 frangio

clock sounds good to me. Another alternative could be tick.

Is it the intention of the function now() to represent the current point of time in either timestamp or blocknum?

I feel the tick or clock will all strongly imply timestamp and could cause trouble if contract developers choose to implement blocknum but client interpreting it as timestamp.

I'd brainstorm something like currentPointOfTime(), well that's a bit unfortunately long, please help find better name

xinbenlv avatar Nov 04 '22 17:11 xinbenlv

Also, realizing snapshot doesn't work at blocknum level. I am proposing #5875 to retrieve TX Num. Wondering if for better security, we should support TX level of voting weight snapshot

xinbenlv avatar Nov 04 '22 17:11 xinbenlv

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Dec 19 '22 00:12 github-actions[bot]

There is still ongoing discution about this EIP (which IMO should happen on the ethereum magician thread, and not here) ... but I believe the proposal state is sufficient to merge as a draft.

If there is anything preventing that from being merged (as a draft), please let me know what needs to be fixed.

Amxx avatar Jan 05 '23 15:01 Amxx

The only rule about the creation date is it can't be in the future.

Pandapip1 avatar Jan 06 '23 18:01 Pandapip1