EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Add EIP-5794: eth/69: add withdrawals to block

Open MariusVanDerWijden opened this issue 3 years ago • 2 comments
trafficstars

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

MariusVanDerWijden avatar Oct 18 '22 09:10 MariusVanDerWijden

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-5794.md

classification
newEIPFile
  • File with name EIPS/eip-5794.md is new and new files must be reviewed
  • This PR requires review from one of [@lightclient, @axic, @samwilsn]

eth-bot avatar Oct 18 '22 09:10 eth-bot

We might not do this after all, since we didn't create a new version when we added the basefee to the header

MariusVanDerWijden avatar Oct 18 '22 14:10 MariusVanDerWijden

Am going to close this, we decided that adding withdrawals to the block does not warrant a new protocol version.

MariusVanDerWijden avatar Nov 22 '22 09:11 MariusVanDerWijden