EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Add EIP-5791: Physical Backed Tokens

Open 2pmflow opened this issue 3 years ago • 4 comments
trafficstars

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

2pmflow avatar Oct 17 '22 15:10 2pmflow

A critical exception has occurred: Message: pr 5791 is already merged; quitting (cc @alita-moore, @mryalamanchi)

eth-bot avatar Oct 17 '22 15:10 eth-bot

That's an awesome project and very interesting real value for decentralized world

ivanmmurciaua avatar Oct 18 '22 16:10 ivanmmurciaua

Awesome project!

edddyguo avatar Oct 19 '22 02:10 edddyguo

@Pandapip1 I moved a chunk to Motivation here https://github.com/ethereum/EIPs/pull/5791/commits/a14103cac4cf6232fce2647c72942f63e04ce460, but was having trouble finding other parts of the spec that are a better fit in Motivation than their current respective sections, based on the prompt for Motivation in the template (The motivation section should describe the "why" of this EIP.). To me, the "why" is to solve for the two enumerated problems, and the rest is "how" the spec solves those problems. Could you clarify what chunks you think are a better fit for the "why"? Happy to make changes as appropriate.

2pmflow avatar Oct 19 '22 16:10 2pmflow

I think it will help develop various interesting contents that can be done offline as well as trading. 

YAYLABS-Snoo avatar Oct 23 '22 04:10 YAYLABS-Snoo

@Pandapip1 thanks for detailed review. Feedback addressed in latest

2pmflow avatar Oct 23 '22 19:10 2pmflow