EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Add EIP-5773: Multi-Resource Token standard

Open ThunderDeliverer opened this issue 3 years ago • 3 comments
trafficstars

This EIP draft proposal includes RMRK team's work on developing an NFT standard where a single NFT can be tied to multiple resources.

ThunderDeliverer avatar Oct 10 '22 21:10 ThunderDeliverer

All tests passed; auto-merging...

(pass) eip-5773.md

classification
updateEIP
  • passed!

(pass) assets/eip-5773/contracts/IMultiAsset.sol

classification
ambiguous
  • file assets/eip-5773/contracts/IMultiAsset.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/contracts/MultiAssetToken.sol

classification
ambiguous
  • file assets/eip-5773/contracts/MultiAssetToken.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/contracts/library/MultiAssetLib.sol

classification
ambiguous
  • file assets/eip-5773/contracts/library/MultiAssetLib.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/contracts/mocks/ERC721ReceiverMock.sol

classification
ambiguous
  • file assets/eip-5773/contracts/mocks/ERC721ReceiverMock.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/contracts/mocks/MultiAssetTokenMock.sol

classification
ambiguous
  • file assets/eip-5773/contracts/mocks/MultiAssetTokenMock.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/contracts/mocks/NonReceiverMock.sol

classification
ambiguous
  • file assets/eip-5773/contracts/mocks/NonReceiverMock.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/contracts/utils/MultiAssetRenderUtils.sol

classification
ambiguous
  • file assets/eip-5773/contracts/utils/MultiAssetRenderUtils.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/hardhat.config.ts

classification
ambiguous
  • file assets/eip-5773/hardhat.config.ts is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/package.json

classification
ambiguous
  • file assets/eip-5773/package.json is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/test/multiasset.ts

classification
ambiguous
  • file assets/eip-5773/test/multiasset.ts is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/test/renderUtils.ts

classification
ambiguous
  • file assets/eip-5773/test/renderUtils.ts is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

eth-bot avatar Oct 10 '22 21:10 eth-bot

I intend to add discussion link at the same time as I will update the EIP number, to reduce the number of pushes to the initial PR.

ThunderDeliverer avatar Oct 10 '22 21:10 ThunderDeliverer

Here's my review so far.

Thank you for the comments, I applied the changes based on them and pushed them

ThunderDeliverer avatar Oct 26 '22 09:10 ThunderDeliverer