EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Update EIP-5679: Move to Last Call

Open xinbenlv opened this issue 3 years ago • 1 comments
trafficstars

creating a PR to accept revisions for EIP-5679. Will update last call deadline before merge

xinbenlv avatar Oct 06 '22 15:10 xinbenlv

A critical exception has occurred: Message: pr 5759 is already merged; quitting (cc @alita-moore, @mryalamanchi)

eth-bot avatar Oct 06 '22 15:10 eth-bot

Should EIP-165 support be optional? That would allow contracts with matching mint/burn functions to be compatible.

Done

I'd expand on (6) a bit. I don't find "with respect to the ERC721TokenReceiver" clear enough. Maybe something like "safeMint MUST implement the same receiver restrictions as safeTransferFrom as defined in EIP-721".

Done. I think your wording is much clearer.

transfer -> transferred on 68/69 and 73/74

Done

You'll need to remove the external links to goerli. If you can, please put the source code in your assets directory.

Done. I removed them to comply with your editorial comment. (For the record I oppose to the restriction for adding implementation in the format of deployment address.)

xinbenlv avatar Oct 27 '22 05:10 xinbenlv

@SamWilsn thanks for reviewing, this PR is ready for merge

xinbenlv avatar Oct 27 '22 05:10 xinbenlv