EIPs
EIPs copied to clipboard
Add EIP-5748: Approval Expiration for EIP-20 Tokens
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:
- The PR edits only existing draft PRs.
- The build passes.
- Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside
. - If matching on email address, the email address is the one publicly listed on your GitHub profile.
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
(fail) eip-5748.md
| classification |
|---|
newEIPFile |
- File with name EIPS/eip-5748.md is new and new files must be reviewed
- This PR requires review from one of [@lightclient, @axic, @samwilsn, @pandapip1]
(pass) assets/eip-5748/eip-5748.sol
| classification |
|---|
ambiguous |
- file assets/eip-5748/eip-5748.sol is associated with EIP 5748; because there are also changes being made to EIPS/eip-5748.md all changes to corresponding assets are also allowed
Hey lucky, I’m still getting up to speed on the language and adaptability on how to use in my projects. Please excuse my absence. If you have any tips on how to catch up as fast as I can, please advise
Sent from my iPhone
On Oct 4, 2022, at 8:34 AM, eth-bot @.***> wrote:
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
(fail) EIPS/eip-draft_erc20_approval_expiration.md
classification ambiguous file 'EIPS/eip-draft_erc20_approval_expiration.md' is not a valid eip file name; all eip files need to be in eip-####.md format. It's assumed however that this has been included because an eip number has not been provided for this eip yet. cc @@.@.@.@. (fail) assets/eip-draft_erc20_approval_expiration/erc20-approval-expiration.sol
classification ambiguous 'assets/eip-draft_erc20_approval_expiration/erc20-approval-expiration.sol' must be in eip-###.md format; this error will be overwritten upon relevant editor approval — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.
@lightclient we're hitting CI failures with the "EIP Walidator". Our references to ERC-20 are being flagged as violations. Should we be referring to ERC-20 as EIP-20?
I really like this idea.
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
(fail) eip-5748.md
classification
newEIPFile
- File with name EIPS/eip-5748.md is new and new files must be reviewed
- This PR requires review from one of [@lightclient, @axic, @SamWilsn, @Pandapip1]
(pass) assets/eip-5748/eip-5748.sol
classification
ambiguous
- file assets/eip-5748/eip-5748.sol is associated with EIP 5748; because there are also changes being made to EIPS/eip-5748.md all changes to corresponding assets are also allowed
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.
Should be reviewed. There is a problem between the account and management account is being reviewed