EIPs
EIPs copied to clipboard
ethereum
Update EIP-1155: Fix arg order for balanceOf
In ERC1155, the function balanceOf is defined as follows:
function balanceOf(address _owner, uint256 _id) external view returns (uint256);
However, in the Split ID bits section of EIP1155, the ordering of args is reversed:
balanceOf(baseTokenNFT, msg.sender);
balanceOf(baseTokenNFT + indexNFT, msg.sender);
balanceOf(baseTokenFT, msg.sender);
This PR simply switches the args to match the spec.
Please fix the EIP Walidator errors.
@Pandapip1 sorry for the trouble, but it looks like the EIP Walidator errors aren't related to the code snippet I changed. Could you advise on how to remove the errors?
@Pandapip1 sorry for the trouble, but it looks like the EIP Walidator errors aren't related to the code snippet I changed. Could you advise on how to remove the errors?
Ah - this changes a final EIP. This is waiting for approval from one of (@coinfork, @AC0DEM0NK3Y, @wighawag) and then we can merge this manually.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
pinging @PhABC @SamWilsn just to make sure this gets addressed before PR is auto-closed. Thanks!
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
I think this change is sufficiently minor that a manual merge is justified. Tagging @SamWilsn - thoughts?
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
The commit b13a653a357f9a099c7cd0efd2466869b97661b2 (as a parent of 304b3dca3b2a6da71ae266ed090d7d7434cd74a4) contains errors. Please inspect the Run Summary for details.