EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

initial draft for EIP-5528 Proposal

Open StartfundInc opened this issue 3 years ago • 2 comments
trafficstars

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

StartfundInc avatar Aug 24 '22 03:08 StartfundInc

All tests passed; auto-merging...

(pass) eip-5528.md

classification
updateEIP
  • passed!

(pass) assets/eip-5528/ERC20Mockup.sol

classification
ambiguous
  • file assets/eip-5528/ERC20Mockup.sol is associated with EIP 5528; because there are also changes being made to EIPS/eip-5528.md all changes to corresponding assets are also allowed

(pass) assets/eip-5528/EscrowContractAccount.sol

classification
ambiguous
  • file assets/eip-5528/EscrowContractAccount.sol is associated with EIP 5528; because there are also changes being made to EIPS/eip-5528.md all changes to corresponding assets are also allowed

(pass) assets/eip-5528/truffule-test.js

classification
ambiguous
  • file assets/eip-5528/truffule-test.js is associated with EIP 5528; because there are also changes being made to EIPS/eip-5528.md all changes to corresponding assets are also allowed

eth-bot avatar Aug 24 '22 03:08 eth-bot

Please fix the EIPW errors

Thanks for review. fixed by new commit. Is there any way bot test before commit?

StartfundInc avatar Aug 24 '22 22:08 StartfundInc

Required: Please run this entire document through a spell and grammar checker like Grammarly.

Why am I not more polite?

Thanks for deep reviewing.

Since you pointed out many areas I should improve, I hid some structural updates. Some easy-fixing parts (ex: requires: 20) have been fixed on the latest commit.

StartfundInc avatar Sep 01 '22 00:09 StartfundInc