EIPs
EIPs copied to clipboard
ethereum
CI: Upgrade EIP-Bot to eip-review-bot
~~Currently WIP.~~ It works.
Has a few advantages over EIP-Bot:
- Smaller, less systemically complex codebase
- Maintenance and features can be developed quicker
- Runs much quicker
Progress:
- [x] Prototype
- [x] E2E testing
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
(fail) .github/workflows/auto-review-bot.yml
| classification |
|---|
ambiguous |
- '.github/workflows/auto-review-bot.yml' must be in eip-###.md format; this error will be overwritten upon relevant editor approval
(fail) config/eip-editors.yml
| classification |
|---|
ambiguous |
- 'config/eip-editors.yml' must be in eip-###.md format; this error will be overwritten upon relevant editor approval
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Pandapip1 can you rebase pls. @SamWilsn - thoughts migrating to eip-review-bot?
I'd like to leave some feedback on the bot itself before we make the switch, but besides that, I have no problem with this!
I have left some feedback on eip-review-bot. Code is very understandable!
My only concern is that there aren't any automated tests that I could see. Personally I'd like to see some automated tests before we switch away from eip-bot. What do you think @lightclient?
I believe my concerns regarding automated testing have mostly been resolved. I am still nervous about switching to a new merge guardian, and would like to see some tests that exercise the whole process (including mocking the GitHub API.)
That said, I think this is sufficiently tested to give it a trial run. Shall we bring it up at the next EIPIP meeting?
Shoot, should've brought this up on EIPIP today. I'm still interested in either getting this merged, or fixing the file deletion bug in the current bot.