EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Update EIP-1: Explicitly state that backward compatible errata are allowed for final EIPs

Open Pandapip1 opened this issue 3 years ago • 9 comments
trafficstars

Pandapip1 avatar Aug 18 '22 15:08 Pandapip1

File EIPS/eip-1.md

Requires 1 more reviewers from @SamWilsn, @axic, @lightclient

eth-bot avatar Aug 18 '22 15:08 eth-bot

At the very least it's hard to determine whether something is backward compatible. I've love to voice my opposition to this change without boarder EIP Editor group consensus. Could I suggest you instead start an informational EIP that gives examples of what's considered backward compatible or not, before making it a EIP-1 rule?

xinbenlv avatar Aug 18 '22 19:08 xinbenlv

Backward compatibility has a very simple definition: if a particular behavior has a satisfiable unambiguous definition, then it can't be changed.

Pandapip1 avatar Aug 18 '22 19:08 Pandapip1

Most often I'd envision a change from author like "hey I want to add this method (but optional/extension) to the ERC interface"

Do we count this type of change as "backward compatible"?

xinbenlv avatar Aug 18 '22 19:08 xinbenlv

Do we count this type of change as "backward compatible"?

That's a really good point. I would say that it wouldn't be backward compatible in the majority of the cases since it's pretty standard to use EIP-165. Not sure about other cases - I'll have to revise the definition.

Pandapip1 avatar Aug 18 '22 20:08 Pandapip1

How about:

If a particular behavior has a satisfiable unambiguous definition, then it can't be changed. If a particular behavior has no definition, then one can't be added. If a particular behavior has a definition that is either unsatisfiable or ambiguous, then it may be changed.

Pandapip1 avatar Aug 18 '22 20:08 Pandapip1

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Sep 14 '22 00:09 github-actions[bot]

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Sep 30 '22 00:09 github-actions[bot]

Still an issue.

Pandapip1 avatar Sep 30 '22 13:09 Pandapip1

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Jan 26 '23 00:01 github-actions[bot]

Dismissing stale bot.

Pandapip1 avatar Jan 26 '23 18:01 Pandapip1

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Feb 10 '23 00:02 github-actions[bot]

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Mar 10 '23 00:03 github-actions[bot]

Dismissing stale bot

Pandapip1 avatar Mar 11 '23 13:03 Pandapip1

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Mar 26 '23 00:03 github-actions[bot]

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

github-actions[bot] avatar May 08 '23 00:05 github-actions[bot]