EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Update EIP-2681: Minor clarification

Open xinbenlv opened this issue 3 years ago • 9 comments
trafficstars

@axic: I was minorly confused by the wording so I propose some clarification..

Change from

Limit account nonce to be between `0` and `2^64-1`.

to Option 1

Limit account nonce to be between `0` and `2^64-1`(inclusive).

or Option 2

Limit account nonce to be `0<=account_nonce<=2^64-1`

to clarify in the summary the inclusivity of two ends

xinbenlv avatar Aug 09 '22 13:08 xinbenlv

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-2681.md

classification
updateEIP
  • eip-2681.md requires approval from one of (@axic)

eth-bot avatar Aug 09 '22 14:08 eth-bot

The commit 005fe3ba075bf6208862548ed126be9ed7376372 (as a parent of 1232e53a2b502a07744d057f3fbff3dccefe746c) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 09 '22 14:08 github-actions[bot]

Thank you. Since there is no concern on the editor side, I will leave it to the author to make a choice of the 3 options or leave it as-is: @axic

xinbenlv avatar Aug 14 '22 02:08 xinbenlv

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Sep 14 '22 00:09 github-actions[bot]

Friendly ping author @axic

xinbenlv avatar Sep 26 '22 20:09 xinbenlv

Thanks @lightclient. I like option 2 better too.

I was personally confused by original wording hence the PR. Let's see if @axic think needed? I am ok either way.

xinbenlv avatar Oct 03 '22 15:10 xinbenlv

@axic friendly ping for author approval. Or let me know if this PR is useful or shall be dropped

xinbenlv avatar Nov 10 '22 22:11 xinbenlv

The bot states only:

eip-2681.md requires approval from one of (@axic)

I wonder if it is not displaying the warning anymore that this is modifying a Final EIP?

axic avatar Nov 10 '22 23:11 axic

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Dec 03 '22 00:12 github-actions[bot]

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

github-actions[bot] avatar Jan 14 '23 00:01 github-actions[bot]