EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Add EIP-5388: Token-Gated HTTP Endpoints

Open TimDaub opened this issue 3 years ago • 13 comments
trafficstars

For now, I'm submitting this proposal as a draft. It essentially generalizes token-gating as implemented by e.g. Ocean Protocol.

Summary of this PR: Screenshot 2022-08-01 at 16 48 33

https://twitter.com/timdaub/status/1554116824006103040

What I could need help with:

  • Not sure what exactly I should write in the "Rationale" section
  • Is it fine to ignore the backward compatibility section for now? It seems this proposal doesn't have to be backward compatible
  • What would be the security implications of such a standard?
  • Have I outlined the EIP-712 section well? My confidence in working with EIP-712 is low, so I'd appreciate feedback, safety reviews, and help

TODOs:

  • [x] X-ABI-ENCODED-INPUT should be prefixed with `EIP-XXXX´ too
  • [x] Create Magician's thread
  • [ ] When requesting the endpoint with authorization, we should probably mandate that the user submits a transaction ID with the executed suggestion too
  • [ ] A server must send a chain-ID along with the suggested encoded abi and a contract address
  • [ ] Consider removing the X- prefix from headers
  • [ ] Consider giving advice about "payable" value in case ETH is expected

TimDaub avatar Aug 01 '22 14:08 TimDaub

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-5388.md

classification
newEIPFile
  • File with name EIPS/eip-5388.md is new and new files must be reviewed
  • This PR requires review from one of [@lightclient, @axic, @samwilsn, @pandapip1]

eth-bot avatar Aug 01 '22 14:08 eth-bot

The commit a0730216878d00441f0305b1e04e66cdcd1e131a (as a parent of 2399a6f7d53ca321a4c7b8e0c6b97f024fd9ea06) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 01 '22 14:08 github-actions[bot]

The commit 361a52efb4ba7fa4770b7a42ad1eb9b3ea81e8ac (as a parent of 14d0e5c5f91a60e4b7b51e29b994d91e35c2ac04) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 01 '22 14:08 github-actions[bot]

The commit e89bf569bf5acd3bada81a991a66ae9dbb5e9769 (as a parent of 9b77df850e8c65407e88ea0d33d025c3af90855c) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 01 '22 14:08 github-actions[bot]

The commit ec9eda758648f72074fa92d6987e8a99dc67c427 (as a parent of f4d1ecca371e2ed2e58eebd596d142c780086428) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 04 '22 11:08 github-actions[bot]

The commit 7dabc749e6dbaea01f5d4901d3e9d780083eead1 (as a parent of 3b992fd850d07832dabd2d05e65be1c1a5777177) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 04 '22 11:08 github-actions[bot]

The commit 176745d4791b5303185bb481d34d2c4867afe396 (as a parent of 0c821bcf29e2444bf1173d46c233761112aea3ec) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 04 '22 11:08 github-actions[bot]

The commit 2ae203ada92f99ea495be41a175ab1682bf472ce (as a parent of 1af84c7a24a8f2631c2e0c86fa35bd857749820f) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 04 '22 11:08 github-actions[bot]

The commit edcab144384e841c3b0c04298387c494bd9933c9 (as a parent of 75483205ad2cfc190f7f6cfe98b16b6260134164) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 04 '22 11:08 github-actions[bot]

The commit f307c7cb4ab954a3edd1fff9e7e65e04276f81dd (as a parent of e69c034d2f8d4dc2d8060984931909b411fadc84) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 04 '22 11:08 github-actions[bot]

The commit c9aa17726e6ee56655ba58c8de5d8b5321135d3a (as a parent of 3f73560ec5abee409b08890e1aeb95ddb57673be) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 04 '22 11:08 github-actions[bot]

The commit cf43827945242fa99b0f915bf49ac02496665fa8 (as a parent of 9704ad526942609de34b02fcdc7b5df83614c4c3) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 04 '22 11:08 github-actions[bot]

شكرا

Rachi26 avatar Sep 25 '22 07:09 Rachi26

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Nov 26 '22 00:11 github-actions[bot]

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Dec 12 '22 00:12 github-actions[bot]

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

github-actions[bot] avatar Jan 24 '23 00:01 github-actions[bot]