EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Extending ERC1155 with approvals by amount

Open ivanmmurciaua opened this issue 3 years ago • 8 comments
trafficstars

Approval by amount extension

ivanmmurciaua avatar Jul 11 '22 09:07 ivanmmurciaua

All tests passed; auto-merging...

(pass) eip-5216.md

classification
updateEIP
  • passed!

(pass) assets/eip-5216/ERC1155ApprovalByAmount.sol

classification
ambiguous
  • file assets/eip-5216/ERC1155ApprovalByAmount.sol is associated with EIP 5216; because there are also changes being made to EIPS/eip-5216.md all changes to corresponding assets are also allowed

eth-bot avatar Jul 11 '22 09:07 eth-bot

Can you also pls delete the package-lock.json?

LICENSE and package-lock.json deleted

ivanmmurciaua avatar Jul 12 '22 16:07 ivanmmurciaua

The commit d3f782740e120e096a7aaf92e53235c39c7bf0ee (as a parent of 95238345f8968f7a4ff977a33c5c7f8d3f763608) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 23 '22 03:07 github-actions[bot]

I don't know what is happening with eth-bot. @MicahZoltu @Pandapip1

ivanmmurciaua avatar Aug 17 '22 14:08 ivanmmurciaua

Oops it appears there might have been a bug.

Pandapip1 avatar Aug 17 '22 16:08 Pandapip1

Oh. There's a problematic branch protection setting. Please disable the "require conversation resolution" option @lightclient.

Pandapip1 avatar Aug 17 '22 17:08 Pandapip1

@Pandapip1 it isn't enabled.

lightclient avatar Aug 17 '22 17:08 lightclient

Wow.. thanks guys

ivanmmurciaua avatar Aug 17 '22 19:08 ivanmmurciaua