EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

EIP-5164: Cross-Chain Execution

Open asselstine opened this issue 3 years ago • 6 comments
trafficstars

The initial draft for the Cross-Chain Execution EIP! 🎉 🎉

Once an EIP number is assigned, I will create a corresponding topic in Ethereum Magicians.

Note: the EIP was born out of a conversation on Ethereum Magicians.

asselstine avatar Jun 15 '22 17:06 asselstine

A critical exception has occurred: Message: pr 5164 is already merged; quitting (cc @alita-moore, @mryalamanchi)

eth-bot avatar Jun 15 '22 17:06 eth-bot

Thanks @MicahZoltu! I will review and update.

asselstine avatar Jun 17 '22 19:06 asselstine

The commit a641fed8dd2d8ca3799bea19b2c77d9528728f64 (as a parent of 18a613e24d3cbb688fbf732e50c9e2aeb8037625) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 26 '22 15:07 github-actions[bot]

@lightclient I believe I've included all of the latest change requests! Let me know if there is anything else

asselstine avatar Jul 28 '22 20:07 asselstine

The commit d7b0fdb37881dad1e5e371abb0e4221111b8fe2e (as a parent of fc86af22e8a94b37d05f8507155682a061f8f613) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 28 '22 20:07 github-actions[bot]

The commit c777eb60f24dbe3c517fa1d63cca27b0e60e9f37 (as a parent of ecf104e06ff2336d628d92622a4cc7ac8e3370c3) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 28 '22 20:07 github-actions[bot]

Actually, @PierrickGT's comments need addressing.

@Pandapip1 I'm collaborating with @asselstine on this EIP, so after discussing with him about it, I've implemented the changes.

PierrickGT avatar Sep 20 '22 23:09 PierrickGT

The executor parameter passed to the relayCalls function has been removed in the following commit: https://github.com/ethereum/EIPs/pull/5164/commits/a478089e0a4e04f9d0fcaff2b5c95169bc5af23c#diff-41efe0617f861cc7330b025ecc86d55fe777d3c503208d83dca04258de4f5f41R55

We have realized during the implementation of this EIP that bridges most often communicate with only one executor contract on the receiving chain. So it is pretty superfluous to pass this address all the time to the relayCalls function.

Applications can decide to set the executor address either through the constructor or via a setter function.

PierrickGT avatar Sep 22 '22 22:09 PierrickGT