EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Static stack use validation for EOF functions.

Open gcolvin opened this issue 3 years ago • 3 comments

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

gcolvin avatar May 26 '22 13:05 gcolvin

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-4750.md

classification
updateEIP
  • eip-4750.md requires approval from one of (@gumb0, @axic, @chfast)

eth-bot avatar May 26 '22 13:05 eth-bot

We generally agree with the direction taken by these changes, and in fact plan to publish our own separate EIP with very similar idea, maybe with somewhat different implementation.

@gcolvin However I'm a bit confused whether this one is still your preferred apporach or did you switch to implementing static validation on top of EIP-2315, and this one should be just closed?

gumb0 avatar Aug 03 '22 16:08 gumb0

@gcolvin is still your preferred apporach or did you switch to implementing static validation on top of EIP-2315, and this one should be just closed?

I'm not concerned with the exact approach, just that as much be checked at validation time as possible. If you have an EIP that does the job then by all means close this PR. EIP-2315 and EIP-4759 are independent -- one can go in whether or not the other goes in. EIP-2315 now specifies it's own validation, so if they both go in there will be some work to harmonize the redundant specs.

gcolvin avatar Aug 03 '22 20:08 gcolvin