EIPs
EIPs copied to clipboard
ethereum
Update EIP-1271: Fix example
All tests passed; auto-merging...
(pass) eip-1271.md
| classification |
|---|
updateEIP |
- passed!
I'm very confused by this PR. It allegedly is a PR against master, but in master this EIP is final rather than last call and this PR shows the EIP still in Last Call.
@PhABC Would you mind checking out your fork and making sure it is otherwise in sync with ethereum/EIPs and that your branch is rebased on master? GitHub shouldn't be having trouble here... so I'm just guessing at what might be wrong.
There's a merge commit in this PR that could be messing things up? I'd recommend resetting this branch to the latest master and cherry-picking the changes you want (without the merge commit.)
Is there some reason why you recommend cherry picking rather than git rebase @SamWilsn?
Is there some reason why you recommend cherry picking rather than
git rebase@SamWilsn?
I've had bad experiences rebasing branches that contain merge commits, but that might just be a me thing.
Ah, good point. One way to deal with that would be to do:
# reset local branch pointer to point at `origin/master`, but leave working directory untouched.
git reset --soft origin/master
# commit working directory charges to local branch
git add .
git commit -m '...'
# force push local branch to origin
git push --force-with-lease origin
There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR still has something weird going on with it as it is allegedly against a Last Call EIP but this EIP is final. Someone needs to fix this, or submit a new issue that is correctly against the current head of this repository.
Are we still interested in getting this merged? I'd prefer getting the git history cleaned up before doing so.
The Git history is fine for me.
You've got to stop making merge commits :rofl:
@Pandapip1 @SamWilsn I think the latest editorial policy is to ignore EIP Walidator warnings for Final EIPs, right?
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.