EIPs
EIPs copied to clipboard
ethereum
Update EIP-1202: Move to Review
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:
- The PR edits only existing draft PRs.
- The build passes.
- Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside
. - If matching on email address, the email address is the one publicly listed on your GitHub profile.
relevent to https://github.com/ethereum/EIPs/issues/1202
All tests passed; auto-merging...
(pass) eip-1202.md
| classification |
|---|
updateEIP |
- passed!
@MicahZoltu I updated the status to review, can you help check if there is anything else I need to do to move this PR forward?
I don't handle ERCs, so you'll have to wait for another editor to get to reviewing this EIP. I left the comment just to hopefully save a round-trip with the reviewer later since I happened to notice it.
Apologies - I missed the "Acknowledgement" section as well.
Per feedback, the section Acknowledgement is now removed.
@xinbenlv a suggestion: in the specification consider using Solidity interfaces as opposed to contracts.
@lightclient do you know if there are anything else I need to resolve before moving on the review?
@axic Thank you for your suggestion, I updated accordingly.
I'd also suggest to check that the code still compiles. Interfaces only allow external functions and not public ones. For a good example ERC see https://eips.ethereum.org/EIPS/eip-3156. It uses interfaces, NatSpec, and additional comments explaining what should happen.
@axic will do. Let me get that validated and get back to you again. Appreciate your feedback!
@axic by the way, I am thinking: for those MUST, I wonder if that would best work as a test. Is the EIP workshop considering any time soon to impose optional TESTs in a ERC so anyone who implement an ERC standard can have a canonical way to validate their standard is certain ERC-conforming, except for just matching the method signature?
I am starting a separate issue for discussion: https://github.com/ethereum/EIPs/issues/3977
This PR appears to wipe out the EIP entirely. Was this a mistake? It definitely should not be merged as is.
There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.