superchain-registry icon indicating copy to clipboard operation
superchain-registry copied to clipboard

Add fraxtal

Open 0xalex88 opened this issue 8 months ago • 4 comments

Follow up on https://github.com/ethereum-optimism/superchain-registry/pull/877

0xalex88 avatar Mar 14 '25 15:03 0xalex88

@bitwiseguy so, trying to generate a geth datadir gives the expected hash but the test code somehow generates a different one:

❯ docker run --rm -ti -v `pwd`/superchain-registry/superchain/extra/genesis/mainnet/fraxtal.json:/genesis.json:ro  us-docker.pkg.dev/oplabs-tools-artifacts/images/op-geth:v1.101503.0 init /genesis.json
INFO [03-14|16:01:49.948] Maximum peer count                       ETH=50 total=50
INFO [03-14|16:01:49.949] Smartcard socket not found, disabling    err="stat /run/pcscd/pcscd.comm: no such file or directory"
INFO [03-14|16:01:49.952] Set global gas cap                       cap=50,000,000
INFO [03-14|16:01:49.953] Initializing the KZG library             backend=gokzg
INFO [03-14|16:01:49.972] Defaulting to pebble as the backing database
INFO [03-14|16:01:49.972] Allocated cache and file handles         database=/root/.ethereum/geth/chaindata cache=16.00MiB handles=16
INFO [03-14|16:01:49.989] Opened ancient database                  database=/root/.ethereum/geth/chaindata/ancient/chain readonly=false
INFO [03-14|16:01:49.990] State schema set to default              scheme=path
ERROR[03-14|16:01:49.991] Head block is not reachable
INFO [03-14|16:01:50.000] Opened ancient database                  database=/root/.ethereum/geth/chaindata/ancient/state readonly=false
INFO [03-14|16:01:50.000] Initialized path database                cache=16.00MiB buffer=64.00MiB history=90000
INFO [03-14|16:01:50.000] Writing custom genesis block
INFO [03-14|16:01:51.216] Successfully wrote genesis state         database=chaindata hash=521982..d6bfaa

but the test fails with:

chainID=252: produced genesis with hash 0xe59a0f592ba5541fbc1b413fb3f35fba80e85ac5699017f3ac4ca7a674252170 but expected 0x521982bd54239dc71269eefb58601762cc15cfb2978e0becb46af7962ed6bfaa

do you have any idea why that would be?

0xalex88 avatar Mar 14 '25 16:03 0xalex88

@0xalex88 - when you ran just add-chain locally did all checks pass locally (ref)? If not, can you share the failure logs?

Also, can you share your full genesis.json file so that we can see if the error is happening at the compression/decompression step or if there is an actual diff? I do see that cast block -r "https://rpc.frax.com/" 0 returns a block hash of 0x521982bd54239dc71269eefb58601762cc15cfb2978e0becb46af7962ed6bfaa, which matches the chain config .toml file you are trying to commit

bitwiseguy avatar Mar 24 '25 14:03 bitwiseguy

@0xalex88 - when you ran just add-chain locally did all checks pass locally (ref)? If not, can you share the failure logs?

Also, can you share your full genesis.json file so that we can see if the error is happening at the compression/decompression step or if there is an actual diff? I do see that cast block -r "https://rpc.frax.com/" 0 returns a block hash of 0x521982bd54239dc71269eefb58601762cc15cfb2978e0becb46af7962ed6bfaa, which matches the chain config .toml file you are trying to commit

Sorry for the delay, add-chain worked, should I force push on thie branch or create a new PR? I only had to change the addresses.go file because it would try to extract the address from the .chainId file but the script finished properly and the genesis hash matches.

0xalex88 avatar Apr 10 '25 23:04 0xalex88

@bitwiseguy force pushed the version created with add-chain

0xalex88 avatar May 15 '25 21:05 0xalex88

closing this as the chain is being added with #877

Wazabie avatar May 22 '25 07:05 Wazabie

Thank you so much @Wazabie ! 🚀

0xalex88 avatar May 22 '25 17:05 0xalex88