optimism
optimism copied to clipboard
Refactor L2 genesis generation - Config
[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite.
Semgrep found 18 sol-style-notice-over-dev-natspec findings:
- packages/contracts-bedrock/scripts/L2Genesis.s.sol: L513, L505, L497, L479, L467, L462, L372, L325, L250, L185, L153, L136, L105, L78, L62, L57, L52, L27
Prefer @notice over @dev in natspec comments
Semgrep found 1 sol-style-malformed-require finding:
- packages/contracts-bedrock/scripts/L2Genesis.s.sol: L379
Malformed require statement style.
Ignore this finding from sol-style-malformed-require.
Semgrep found 1 sol-style-notice-over-dev-natspec finding:
- packages/contracts-bedrock/scripts/libraries/L2GenesisHelpers.sol: L24
Prefer @notice over @dev in natspec comments
Semgrep found 6 sol-style-return-arg-fmt findings:
- packages/contracts-bedrock/scripts/L2Genesis.s.sol: L462
- packages/contracts-bedrock/scripts/DeployConfig.s.sol: L314, L312, L299, L239, L213
Named return arguments to functions must be appended with an underscore (_)
Semgrep found 1 sol-style-notice-over-dev-natspec finding:
- packages/contracts-bedrock/scripts/L2Genesis.s.sol: L546
Prefer @notice over @dev in natspec comments
Semgrep found 5 sol-style-notice-over-dev-natspec findings:
Prefer @notice over @dev in natspec comments
Semgrep found 1 sol-style-notice-over-dev-natspec finding:
- packages/contracts-bedrock/scripts/L2Genesis.s.sol: L63
Prefer @notice over @dev in natspec comments
Semgrep found 2 sol-style-notice-over-dev-natspec findings:
Prefer @notice over @dev in natspec comments
Semgrep found 1 sol-style-return-arg-fmt finding:
- packages/contracts-bedrock/scripts/Artifacts.s.sol: L169
Named return arguments to functions must be appended with an underscore (_)
Semgrep found 2 sol-style-notice-over-dev-natspec findings:
Prefer @notice over @dev in natspec comments
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.
