optimism icon indicating copy to clipboard operation
optimism copied to clipboard

Refactor L2 genesis generation - Config

Open spacesailor24 opened this issue 1 year ago • 9 comments

spacesailor24 avatar Feb 03 '24 00:02 spacesailor24

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

Current dependencies on/for this PR:

  • develop
    • PR #9558 Graphite
      • PR #9557 Graphite
        • PR #9410 Graphite
          • PR #9317 Graphite
            • PR #9328 Graphite 👈

This stack of pull requests is managed by Graphite.

spacesailor24 avatar Feb 03 '24 00:02 spacesailor24

Semgrep found 18 sol-style-notice-over-dev-natspec findings:

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Semgrep found 1 sol-style-malformed-require finding:

  • packages/contracts-bedrock/scripts/L2Genesis.s.sol: L379

Malformed require statement style.

Ignore this finding from sol-style-malformed-require.

semgrep-app[bot] avatar Feb 03 '24 00:02 semgrep-app[bot]

Semgrep found 1 sol-style-notice-over-dev-natspec finding:

  • packages/contracts-bedrock/scripts/libraries/L2GenesisHelpers.sol: L24

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

semgrep-app[bot] avatar Feb 13 '24 03:02 semgrep-app[bot]

Semgrep found 6 sol-style-return-arg-fmt findings:

  • packages/contracts-bedrock/scripts/L2Genesis.s.sol: L462
  • packages/contracts-bedrock/scripts/DeployConfig.s.sol: L314, L312, L299, L239, L213

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

semgrep-app[bot] avatar Feb 13 '24 05:02 semgrep-app[bot]

Semgrep found 1 sol-style-notice-over-dev-natspec finding:

  • packages/contracts-bedrock/scripts/L2Genesis.s.sol: L546

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

semgrep-app[bot] avatar Feb 14 '24 05:02 semgrep-app[bot]

Semgrep found 5 sol-style-notice-over-dev-natspec findings:

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

semgrep-app[bot] avatar Feb 14 '24 07:02 semgrep-app[bot]

Semgrep found 1 sol-style-notice-over-dev-natspec finding:

  • packages/contracts-bedrock/scripts/L2Genesis.s.sol: L63

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

semgrep-app[bot] avatar Feb 14 '24 08:02 semgrep-app[bot]

Semgrep found 2 sol-style-notice-over-dev-natspec findings:

  • packages/contracts-bedrock/scripts/L2Genesis.s.sol: L280, L164

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Semgrep found 1 sol-style-return-arg-fmt finding:

  • packages/contracts-bedrock/scripts/Artifacts.s.sol: L169

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

semgrep-app[bot] avatar Feb 15 '24 05:02 semgrep-app[bot]

Semgrep found 2 sol-style-notice-over-dev-natspec findings:

  • packages/contracts-bedrock/scripts/L2Genesis.s.sol: L661, L491

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

semgrep-app[bot] avatar Feb 15 '24 05:02 semgrep-app[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Mar 02 '24 01:03 github-actions[bot]