op-node: Make sealing duration value configurable

[trianglesphere]

trafficstars

Description

This makes the sealing duration value configuration via flags.

[protolambda]

@trianglesphere

I added a commit that makes sure there is no negative value, and that 0 automatically becomes the 50ms. There were many instantiations of the op-node config (and indirectly the driver sequencer config) across the testing that were broken otherwise. If you need an extremely low sequencer sealing duration, you can always configure it explicitly to 1ms. Or even 1ns. And I added a doc comment on the config field.

What do you think of these changes? And what do you intend to configure it to?

[protolambda]

/ci authorize 3ebd18bbbc4e3b9a9cd3bd541f9855790b6766ba

[trianglesphere]

@trianglesphere

I added a commit that makes sure there is no negative value, and that 0 automatically becomes the 50ms. There were many instantiations of the op-node config (and indirectly the driver sequencer config) across the testing that were broken otherwise.

If you need an extremely low sequencer sealing duration, you can always configure it explicitly to 1ms. Or even 1ns.

And I added a doc comment on the config field.

What do you think of these changes? And what do you intend to configure it to?

Those changes make sense. I didn't realize how many times the struct was created elsewhere. Our intention is to increase the duration, but we're not sure on the exact value yet. We don't think that we would benefit from lowering it.

[opgitgovernance]

This pr has been automatically marked as stale and will be closed in 5 days if no updates

[trianglesphere]

@protolambda I think this needs another bump to CI