optimism icon indicating copy to clipboard operation
optimism copied to clipboard

op-program: store prestate versions in json files

Open bitwiseguy opened this issue 1 year ago • 1 comments

Context: https://discord.com/channels/1244729134312198194/1289257665356234898/1296670887445139526

Storing standard and candidate releases separately. The superchain-registry validation checks MUST only check against standard releases.

Tests

Manually triggered daily preimage-reproducibility job to ensure its working correctly

bitwiseguy avatar Oct 18 '24 15:10 bitwiseguy

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.86%. Comparing base (d2c5146) to head (5175f16). Report is 22 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12523      +/-   ##
===========================================
- Coverage    65.04%   64.86%   -0.18%     
===========================================
  Files           54       54              
  Lines         4460     4460              
===========================================
- Hits          2901     2893       -8     
- Misses        1382     1391       +9     
+ Partials       177      176       -1     
Flag Coverage Δ
cannon-go-tests 64.86% <ø> (-0.18%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

codecov[bot] avatar Oct 18 '24 17:10 codecov[bot]

Semgrep found 1 sol-style-notice-over-dev-natspec finding:

  • packages/contracts-bedrock/src/cannon/interfaces/IPreimageOracle.sol

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Semgrep found 1 golang_fmt_errorf_no_params finding:

  • op-deployer/pkg/deployer/bootstrap/bootstrap.go

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

semgrep-app[bot] avatar Oct 21 '24 14:10 semgrep-app[bot]