optimism
optimism copied to clipboard
op-node: Add Metrics
Description
This adds one new metric, sequencer_active to report if the sequencer is active or not.
This also modifies transactions_sequenced_total. It is transformed from a Gauge (incorrectly called a counter previously) to a CounterVec. It is labelled with type where the value is l1_info_deposit, deposit, and txns to differentiate the different kinds of transactions.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 64.14%. Comparing base (
6d36d68) to head (4b1f84f). Report is 1 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #12408 +/- ##
===========================================
- Coverage 64.32% 64.14% -0.19%
===========================================
Files 52 52
Lines 4348 4348
===========================================
- Hits 2797 2789 -8
- Misses 1376 1385 +9
+ Partials 175 174 -1
| Flag | Coverage Δ | |
|---|---|---|
| cannon-go-tests | 64.14% <ø> (-0.19%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
These changes are generally good @trianglesphere, thank you. Left a few comments, curious what you think
@tynes I cleaned up some of the logic to avoid duplicating code and simplified the deposit count. Ideally we'd be able to split out each type of txn, but having the deposit vs non deposit split already is a big step forward.
/ci authorize 414e4fb540c1cb8df030123c83dcf48fb6d10c12
/ci authorize 4a60f1bb59d79e83bff9f24703876b5074d9aaae