optimism icon indicating copy to clipboard operation
optimism copied to clipboard

feat: last few Drippie management tweaks

Open smartcontracts opened this issue 1 year ago • 4 comments

Description

  • Updates ManageDrippie so that it no longer relies on the deployment file (which we don't want to commit) and instead has users directly configure the DripCheck contract addresses in the drippie config file.
  • Commits the latest Sepolia drippie config.
  • Adds a new script to turn a Forge transaction dry run file into a Safe transaction builder JSON so that we can easily install drips on mainnet where a Safe will be used.

smartcontracts avatar Jun 12 '24 18:06 smartcontracts

Semgrep found 7 todos_require_linear findings:

Please create a GitHub ticket for this TODO.

Ignore this finding from todos_require_linear.

semgrep-app[bot] avatar Jun 12 '24 18:06 semgrep-app[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.26%. Comparing base (363c5d7) to head (3b8de93). Report is 297 commits behind head on develop.

:exclamation: There is a different number of reports uploaded between BASE (363c5d7) and HEAD (3b8de93). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (363c5d7) HEAD (3b8de93)
chain-mon-tests 2 1
cannon-go-tests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #10810       +/-   ##
============================================
- Coverage    54.78%   39.26%   -15.53%     
============================================
  Files           38       27       -11     
  Lines         2944     1821     -1123     
  Branches       415      415               
============================================
- Hits          1613      715      -898     
+ Misses        1299     1106      -193     
+ Partials        32        0       -32     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests 27.14% <ø> (ø)
sdk-tests 40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

codecov[bot] avatar Jun 12 '24 19:06 codecov[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jun 27 '24 01:06 github-actions[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jul 12 '24 01:07 github-actions[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jul 28 '24 01:07 github-actions[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Aug 12 '24 01:08 github-actions[bot]