asterisc icon indicating copy to clipboard operation
asterisc copied to clipboard

Update monorepo dependency to Holocene release commit

Open mininny opened this issue 10 months ago • 1 comments
trafficstars

Description

Update Optimism monorepo's dependency to holocene release commit https://github.com/ethereum-optimism/optimism/commit/8bf7ff60f34a7c5082cec5c56bed1f76cc1893ad.

Includes the following changes:

  • Update git submodule of optimism and forge-std
  • Update code changes from the monorepo dependency
  • Update Deploy scripts, especially for changed solidity file location in imports
  • Update CircleCI pipeline, mostly mirrored from monorepo updates
    • Remove geth-version-checker.sh
  • Update geth abigen dependency and generated bindings
  • Update op-program-test data and test data generation script

One specific change to note is: https://github.com/ethereum-optimism/asterisc/pull/136/commits/cb5e8b2848253ab951c620fc1263fd350313c669

  • Currently, Asterisc is aimed to only support Kona. However, the testing infrastructure (such as op-e2e tests) rely on running Asterisc with op-program.
  • In the latest op-program version, the op-program introduces the usage of syscall SysNanosleep.
  • However, this syscall is known to be not used in Kona and thus is safe to be not implemented.
  • As we need to run op-program with Asterisc for now, this PR will no-op the syscall SysNanosleep. In a future work, we'll remove testing with op-program from Asterisc, which will effectively allow us to remove this exception.

One change in CI pipeline: https://github.com/ethereum-optimism/asterisc/pull/136/commits/edb234c33487f4f234c09b131afb33668d19af9d

  • Run mise install in monorepo as well
  • Change ci-builder image to cimg/base for more lightweight ci

Tests

All existing circleci tests are passing.

mininny avatar Jan 23 '25 04:01 mininny

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.42%. Comparing base (7654638) to head (84dda89). Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   62.45%   62.42%   -0.04%     
==========================================
  Files          27       27              
  Lines        4158     4154       -4     
==========================================
- Hits         2597     2593       -4     
  Misses       1423     1423              
  Partials      138      138              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 23 '25 05:01 codecov-commenter